"Ghost golden" ships - bug or feature?

General discussion for players of Oolite.

Moderators: winston, another_commander

Post Reply
Rustem
Deadly
Deadly
Posts: 166
Joined: Mon May 25, 2015 5:23 pm
Location: Russia

"Ghost golden" ships - bug or feature?

Post by Rustem » Fri Oct 06, 2017 3:55 pm

Image

It is appearing after apply of extra weapons (missiles, explosion) by player and NPC-ships. This ships has NaN temperatures and energy. It is bug or feature?

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13567
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: "Ghost golden" ships - bug or feature?

Post by Cody » Fri Oct 06, 2017 3:59 pm

A bug, I'd think - got a log?

Rustem
Deadly
Deadly
Posts: 166
Joined: Mon May 25, 2015 5:23 pm
Location: Russia

Re: "Ghost golden" ships - bug or feature?

Post by Rustem » Mon Oct 09, 2017 6:24 am

Found error in the log:

Code: Select all

11:10:17.474 [spawnExtraThargoids]: Spawning of any thargoid: tharglet_Thargorn_Treat
11:10:36.140 [oxp-standards.deprecated]: dealEnergyDamageWithinDesiredRange is deprecated for <ShipEntity 0xfe80268>{"Thargoid Gruntbuggly" position: (-22408.8, -99342, 675297) scanClass: CLASS_THARGOID status: STATUS_IN_FLIGHT}
What's need edit in ExtraThargoids OXP in the function dealEnergyDamageWithinDesiredRange? Replace on new method?

It is exist in deprecated OXP: Missiles and Bomb OXP also(rmb-fragmissileAI.plist):

Code: Select all

DETONATE = {
	ENTER = ("setDesiredRangeTo: 250.0", dealEnergyDamageWithinDesiredRange, becomeExplosion, "spawn: rmb-fragparticle 20"); 
        EXIT = (); 
        UPDATE = (); 
    };
[*] Missile explosions
The AI command dealEnergyDamageWithinDesiredRange is obsolete as it has bugs especially apparent at low frame rates. The JS method dealEnergyDamage is recommended.

UK_Eliter
---- E L I T E ----
---- E L I T E ----
Posts: 1087
Joined: Sat Sep 12, 2009 11:58 pm
Location: Essex (mainly industrial and occasionally anarchic)

Re: "Ghost golden" ships - bug or feature?

Post by UK_Eliter » Thu Oct 12, 2017 8:12 pm

> What's need edit in ExtraThargoids OXP in the function dealEnergyDamageWithinDesiredRange? Replace on new method?

I'm on this (i.e. will fix it), since the method in question is not merely depreciated but buggy. Asking people to fix merely depreciated methods is . . perhaps just a little too keen . . depending on how lazy OXP-ers are!

EDITED to fix something having gone rather wrong with the English.
Last edited by UK_Eliter on Thu Oct 12, 2017 9:35 pm, edited 2 times in total.

Rustem
Deadly
Deadly
Posts: 166
Joined: Mon May 25, 2015 5:23 pm
Location: Russia

Re: "Ghost golden" ships - bug or feature?

Post by Rustem » Thu Oct 12, 2017 8:45 pm

UK_Eliter wrote:
Thu Oct 12, 2017 8:12 pm
> What's need edit in ExtraThargoids OXP in the function dealEnergyDamageWithinDesiredRange? Replace on new method?

I'm on this (i.e. will fix it), since the method in question is not merely depreciated but buggy. Asking people to fix merely depreciated methods is . . would be perhaps just a little too keen . . depending on how lazy OXP-ers are!
I agree.

But these(ships/entity) cannot be killed. These is immortal. :lol:

Post Reply