[Trunk] Reading OXZ from nested OXP directory

For test results, bug reports, announcements of new builds etc.

Moderators: another_commander, winston, Getafix

Post Reply
User avatar
Keeper
---- E L I T E ----
---- E L I T E ----
Posts: 270
Joined: Fri Feb 01, 2013 7:44 am
Location: Indian Hills, Nevada, USA

[Trunk] Reading OXZ from nested OXP directory

Post by Keeper »

On the PC version at least, I noticed that 1.79 will read an OXZ file that is not directly in the "AddOns" folder, but rather nested inside an OXP folder, e.g.:
Oolite/AddOns/MrFlibble.oxp/IsVeryCross.oxz

Should it be doing that?

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: [Trunk] Reading OXZ from nested OXP directory

Post by cim »

Until we get around to a better way of letting players organise their AddOns folder into subfolders, yes.

User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: [Trunk] Reading OXZ from nested OXP directory

Post by JensAyton »

I’m gonna go with “no”.

Supporting subfolders should just be a matter of moving the [dirEnum skipDescendents]; at ResourceManager.m:251 up into the if case. (I still maintain that not calling it in the if case has always been a bug.) To avoid amusing shenanigans it would be best to filter out symlinks, though.

Post Reply