Scripters cove

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

User avatar
Lone_Wolf
---- E L I T E ----
---- E L I T E ----
Posts: 545
Joined: Wed Aug 08, 2007 10:59 pm
Location: Netherlands

Re: Scripters cove

Post by Lone_Wolf » Sat Dec 06, 2014 1:28 pm

missionScreenOpportunity wrote: The missionScreenOpportunity handler is called if there are no mission / report screens active, and the player is docked to a station. It gets fired at game startup, upon docking, and after a docking report or previous mission screen has ended.
I'm trying to decide whether OxpConfig needs to use the missionScreenOpportunity handler.

OxpConfig does use missionRunScreen , but only calls it if the following are true :
- Player accesses F2 Game Options while docked
- when F7 is pressed while GUI_SCREEN_GAMEOPTIONS is true, OxpConfig fires it's owns screens.

These checks could be done in a missionScreenOpportunity handler, but is it needed to avoid clashes ?
OS : Arch Linux 64-bit - rolling release

OXPs : My user page

I am subscribed to the threads for my oxps, if you need my attention just post in them or send a pm.

User avatar
Svengali
---- E L I T E ----
---- E L I T E ----
Posts: 2365
Joined: Sat Oct 20, 2007 2:52 pm

Re: Scripters cove

Post by Svengali » Sun Dec 07, 2014 10:12 am

Lone_Wolf wrote:These checks could be done in a missionScreenOpportunity handler, but is it needed to avoid clashes ?
No. You don't need it if your script shows the next screen in your choice handling.

If you really want to keep the F2->F7 activation you could use the following pseudocode for guiScreenChanged.
But then you should also handle the Timer on shipDied and shipWillLaunchFromStation (even though Oolite should stop Timers in worldScripts).

Code: Select all

if(!player.ship || !player.ship.isValid || !player.ship.docked) return;
switch(guiScreen){
	case "GUI_SCREEN_OPTIONS":
		set activation
		if !Timer
			new Timer calling this.guiScreenChanged
		break;
	case "GUI_SCREEN_SYSTEM_DATA":
		if activation
			start handling
		- no break here!!!
	default:
		delete activation
		if Timer
			stop Timer
			delete Timer
}

User avatar
Wildeblood
---- E L I T E ----
---- E L I T E ----
Posts: 2161
Joined: Sat Jun 11, 2011 6:07 am
Location: Western Australia
Contact:

Re: Scripters cove

Post by Wildeblood » Wed Jan 07, 2015 10:02 am

How late in the witchspace countdown can you set a scripted mis-jump. When playerShipEnteringWitchspaceRealSoonNow shipWillEnterWitchspace fires, and you know it's too late for the player to cancel the countdown, is it too late to do some calculatin' and set the mis-jump? Or does one have to do the calculations when the countdown starts and reverse them if the jump fails or is cancelled?

Edit:Y'see, Norby knew what I meant.
Last edited by Wildeblood on Wed Jan 07, 2015 10:45 am, edited 1 time in total.

User avatar
Norby
---- E L I T E ----
---- E L I T E ----
Posts: 2549
Joined: Mon May 20, 2013 9:53 pm
Location: Budapest, Hungary (Mainly Agricultural Democracy, TL10)
Contact:

Re: Scripters cove

Post by Norby » Wed Jan 07, 2015 10:26 am

Wildeblood wrote:How late in the witchspace countdown can you set a scripted mis-jump.
[wiki]Misjump_Analyzer[/wiki] set it in shipWillEnterWitchspace.

User avatar
Wildeblood
---- E L I T E ----
---- E L I T E ----
Posts: 2161
Joined: Sat Jun 11, 2011 6:07 am
Location: Western Australia
Contact:

Re: Scripters cove

Post by Wildeblood » Wed Jan 07, 2015 11:06 am

Thank you, Norby.

So this should cause a mis-jump every time you try to jump further than 5 ly...? Yes...?:-

Code: Select all

this.shipWillEnterWitchspace = function (cause) {

if (cause !== "standard jump") {return}

var range = System.infoForSystem(galaxyNumber, system.ID).distanceToSystem(System.infoForSystem(galaxyNumber, player.ship.targetSystem))

if (range > 5.0) {player.ship.scriptedMisjump = true}

}
Now the trickier bit... a related function when you arrive in the new system to check how far you just jumped, that must discount jumps arriving from interstellar space. One that can display a message like "Congratulations, you just jumped 4.9 ly without a mis-jump." How would you do that?

User avatar
Wildeblood
---- E L I T E ----
---- E L I T E ----
Posts: 2161
Joined: Sat Jun 11, 2011 6:07 am
Location: Western Australia
Contact:

Re: Scripters cove

Post by Wildeblood » Wed Jan 07, 2015 11:44 am

Code: Select all

this.wasANormalJump = true;
this.jumpLimit = 5.0;

this.shipWillEnterWitchspace = function (cause) {

if (cause !== "standard jump") {
    this.wasANormalJump = false;
   return;
}
if (system.isInterstellarSpace) {
    this.wasANormalJump = false;
}

var range = System.infoForSystem(galaxyNumber, system.ID).distanceToSystem(System.infoForSystem(galaxyNumber, player.ship.targetSystem))

if (range > this.jumpLimit) {player.ship.scriptedMisjump = true}

}

Code: Select all

this.shipWillExitWitchspace = function()
{
    if (system.isInterstellarSpace) {this.wasANormalJump = false}

     if (this.wasANormalJump) {player.consoleMessage("Congratulations, you just jumped without a mis-jump.", 5)}
}
Okay, so I've arrived in a new system and confirmed neither the arrival nor departure systems were interstellar space. But how to record how far I've just jumped?

User avatar
Norby
---- E L I T E ----
---- E L I T E ----
Posts: 2549
Joined: Mon May 20, 2013 9:53 pm
Location: Budapest, Hungary (Mainly Agricultural Democracy, TL10)
Contact:

Re: Scripters cove

Post by Norby » Wed Jan 07, 2015 2:03 pm

Wildeblood wrote:how to record how far I've just jumped?
Save range into a this.$range variable if not in interstellar space. You should use $ or _ prefix in global script variables to prevent collision with existing or future core properties.

If you need to stay over save and load game then use missionVariables but this is more complex and slow so you should store these in global script variables during run and save in playerWillSaveGame only.

User avatar
jh145
Dangerous
Dangerous
Posts: 94
Joined: Thu Dec 25, 2014 8:39 pm

World scripts and shipdata

Post by jh145 » Sun Feb 08, 2015 11:03 pm

Hi, two questions ...
  1. How can I get my script to see all ships currently defined by the game? That's ship type, like "[ferdelance]", not spawned instance, so I can have a menu of things from which to select for creative spawning.
  2. What's the cleanest way of maintaining "global" state? Specifically, I want to record a running score for a couple of ship groups, and I'd like any ship to be able to signal back to the world script when something's happened that should cause the score to update. I can define callbacks in the world script, but not global state (it seems), because "this._score" resolves to the caller's "_score" variable, not the world script's. I don't need to save "_score" between games, so where should it go? In the Player entity?
Thanks.

User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: Scripters cove

Post by JensAyton » Mon Feb 09, 2015 12:26 am

If you call methods in the world script like this:

Code: Select all

var myWorldScript = worldScripts["jh145_myWorldScript"];
myWorldScript.$myMethod(...);
…then this will be the worldscript inside $myMethod.

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: World scripts and shipdata

Post by cim » Mon Feb 09, 2015 7:42 am

jh145 wrote:How can I get my script to see all ships currently defined by the game? That's ship type, like "[ferdelance]", not spawned instance, so I can have a menu of things from which to select for creative spawning.
The static methods of the ship class. In this case, Ship.keys() - note the capital S on 'Ship' - will do what you've asked for, though Ship.keysForRole() might be more useful.

A useful trick to avoid having to mess around with 'this':
{{EDIT: deleted this since it's not quite right - see a few posts down for the correct one.}}
Last edited by cim on Mon Feb 09, 2015 7:38 pm, edited 1 time in total.

User avatar
spara
---- E L I T E ----
---- E L I T E ----
Posts: 2553
Joined: Wed Aug 15, 2012 4:19 am
Location: Finland

Re: Scripters cove

Post by spara » Mon Feb 09, 2015 12:14 pm

Does adding ships with addGroup rather than addShips affect their AI behaviour?

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Scripters cove

Post by cim » Mon Feb 09, 2015 5:50 pm

spara wrote:Does adding ships with addGroup rather than addShips affect their AI behaviour?
Yes - grouped ships will receive messages from ship.requestHelpFromGroup() and ship.notifyGroupOfWormhole(), and be counted as allied for determining combat odds and ignoring friendly fire. There are other effects in a lot of AIs where ships will coordinate actions through their group leader.

Though you can add them with addShips and group them up separately for the same effect - it's being in the same group, not how they got into it, which makes the difference.

User avatar
Svengali
---- E L I T E ----
---- E L I T E ----
Posts: 2365
Joined: Sat Oct 20, 2007 2:52 pm

Re: World scripts and shipdata

Post by Svengali » Mon Feb 09, 2015 7:07 pm

cim wrote:A useful trick to avoid having to mess around with 'this':

Code: Select all

this.name = "My world script";
var self = this;
This ends in the global scope. Better avoid it.

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Scripters cove

Post by cim » Mon Feb 09, 2015 7:37 pm

Svengali wrote:This ends in the global scope. Better avoid it.
Oh, that's annoying.

Okay, slight modification needed, then:

Code: Select all

this.name = "My world script";

(function() { // this line starts an anonymous function scope to get things out of global space

var self = this;

this.startUp = function() {
  this._score = 0;
}

this._myCallbackFunction = function() {
  // ...
  self._score += 1;
}

}.call(this)); // and this line closes that scope and executes the function to define the variables

User avatar
spara
---- E L I T E ----
---- E L I T E ----
Posts: 2553
Joined: Wed Aug 15, 2012 4:19 am
Location: Finland

Re: Scripters cove

Post by spara » Mon Feb 09, 2015 8:37 pm

cim wrote:
spara wrote:Does adding ships with addGroup rather than addShips affect their AI behaviour?
Yes - grouped ships will receive messages from ship.requestHelpFromGroup() and ship.notifyGroupOfWormhole(), and be counted as allied for determining combat odds and ignoring friendly fire. There are other effects in a lot of AIs where ships will coordinate actions through their group leader.

Though you can add them with addShips and group them up separately for the same effect - it's being in the same group, not how they got into it, which makes the difference.
Nice. This is useful with some of the vintage oxps that add pirates with addShips. With the old pirate ship pool and AIs those could be quite deadly and very agressive, but with the new basic pirate pool and AI they seem to be weak loners that very easily wimp out. When adding them as a group, it at least looks like they are more eager to attack. An easy way to keep some some old stuff alive it seams.

I could of course use some of the old AIs that are still there, but I'd rather use the new ones. They are much more elegant.

Post Reply