Oolite Bulletins

For information and discussion about Oolite.
It is currently Mon Dec 18, 2017 6:21 pm

All times are UTC




Post new topic  Reply to topic  [ 989 posts ]  Go to page Previous 162 63 64 65 66
Author Message
 Post subject: Re: Trunk nightly
PostPosted: Sun Sep 10, 2017 1:47 pm 
Offline
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral

Joined: Wed Feb 28, 2007 7:54 am
Posts: 5029
Got a bit of a scare with this, but it seems it's all good. Cody, your log is full of this stuff:
Quote:
21:52:16.347 [collisionRegion.debug]: DEBUG Testing collision between <ShipEntity 0xdbddea0>{"Asteroid" position: (7715.58, 51459.2, 294834) scanClass: CLASS_ROCK status: STATUS_IN_FLIGHT} (NO) and <ShipEntity 0xdbdec30>{"Asteroid" position: (8081.83, 52011.4, 295344) scanClass: CLASS_ROCK status: STATUS_IN_FLIGHT} (NO)
What happened is that you accidentally turned on the collisions check debug flag, which is activated by pausing and pressing "b". The trunk is still stable (phew).


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Sun Sep 10, 2017 2:09 pm 
Offline
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
User avatar

Joined: Sat Jul 04, 2009 9:31 pm
Posts: 12971
Location: Corke's Drift
<scratches head - chortles> Pause+b? No idea how I could've done that, but there you go - thanks!

_________________
The only good fnord is a dead fnord!


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Tue Sep 19, 2017 11:47 pm 
Offline
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
User avatar

Joined: Sat Jul 04, 2009 9:31 pm
Posts: 12971
Location: Corke's Drift
Quote:
EDIT 2017-09-15
Good news. Just got a spare hdd to proceed with the troubleshooting.
Due to R/L priorities, I will be taking over these tasks this Monday.
Cool! I'd missed those updates as edits don't show as a new post.

_________________
The only good fnord is a dead fnord!


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Sat Sep 30, 2017 1:06 pm 
Offline
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
User avatar

Joined: Sat Jul 04, 2009 9:31 pm
Posts: 12971
Location: Corke's Drift
The auto-updater seems to be working.

_________________
The only good fnord is a dead fnord!


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Mon Oct 02, 2017 7:50 am 
Offline
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
User avatar

Joined: Tue Apr 01, 2008 12:55 pm
Posts: 861
Location: A small ice asteroid, orbiting Oresrati in Galaxy 8 (a.k.a. northwest Armorica).
Quote:
The auto-updater seems to be working.
Well, the server is temporarily up, since there were some code updates.
It is still unstable, though. :(

_________________
Xubuntu 14.04LTS / Windows 7 Home Premium
Intel Core 2 Quad Q9450 2.66GHz - 6GB DDR2 - Palit GeForce GTX 750 Ti StormX Dual (2048MB DDR5)
"Any sufficiently advanced information is indistinguishable from noise." [Newman, Lachmann, Moore]


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Fri Oct 06, 2017 9:35 pm 
Offline
Commodore
Commodore
User avatar

Joined: Sun Jan 08, 2006 7:32 pm
Posts: 148
For me, the direction cue indicator in the HUD is broken in head of master.
Probably since 24bf8a05.

Changing this:
[[_reticleColors objectAtIndex:cueColorIndex] greenComponent]
to this:
[(OOColor*)[_reticleColors objectAtIndex:cueColorIndex] greenComponent]
(for all components in both arrays)
fixes it.

It also gets rid of compiler warnings for "Multiple Methods for xxxComponent".

Here is a diff that does just that.
This one is a bit nicer.


(OSX 10.10.5, xcode 7.1)


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Fri Oct 06, 2017 10:10 pm 
Offline
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral

Joined: Wed Feb 28, 2007 7:54 am
Posts: 5029
No problem merging your fix (the second one is the good one to go with), but what exactly was broken with the direction cue before?


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Fri Oct 06, 2017 10:42 pm 
Offline
Commodore
Commodore
User avatar

Joined: Sun Jan 08, 2006 7:32 pm
Posts: 148
Quote:
what exactly was broken with the direction cue before?
It did not show up at all.

I noticed it missing, checked equipment and OXPs, then realised I ran trunk. Tried 1.84 and it was there.
So I looked at where it should be drawn, saw a bunch of warnings and a recent change. Tried this and it worked.

I don't know why. Stepping through in the debugger, it goes into OOColor, not NSColor, but afterwards, both arrays show {0,0,0,0}. Even when running debug build, which I guess doesn't optimize it away.

I could look into it a bit more later.


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Fri Oct 06, 2017 10:50 pm 
Offline
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral

Joined: Wed Feb 28, 2007 7:54 am
Posts: 5029
I think your fix is OK and will commit it shortly. As far as I can tell it is the same code behaviour, which is why I asked what was wrong. It is actually quite a bit cleaner than what we had there. Also, please check your PMs in a couple of minutes.


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Sat Oct 07, 2017 10:45 am 
Offline
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral

Joined: Wed Feb 28, 2007 7:54 am
Posts: 5029
The retricle direction cue indicator should now be back on the Macs. I committed also a few more warning fixes of the same type as those corrected by hoqllnq, so now the reticle should be OK also for targeting wormholes.


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Sat Oct 07, 2017 5:21 pm 
Offline
Commodore
Commodore
User avatar

Joined: Sun Jan 08, 2006 7:32 pm
Posts: 148
Here is another one.
It implements MyOpenGLView::stringToClipboard() for Mac,
so you can get the OXP info URLs from the manager.

By the way, is this the appropriate place to post these, seeing as it is not a bug report, or is there a 'patch submission'-thread?


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Sat Oct 07, 2017 5:47 pm 
Offline
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral

Joined: Wed Feb 28, 2007 7:54 am
Posts: 5029
Quote:
Here is another one.
It implements MyOpenGLView::stringToClipboard() for Mac,
so you can get the OXP info URLs from the manager.
Thanks for that. Should there be a check that the string passed to to the method is not nil or it works OK all the same? Unfortunately I cannot test it myself. If it is OK, I will commit this once we have a confirmation.
Quote:
By the way, is this the appropriate place to post these, seeing as it is not a bug report, or is there a 'patch submission'-thread?
The best way to send in patches is to submit them as pull requests on github. You can find information on how to do this here.


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Sat Oct 07, 2017 6:03 pm 
Offline
Commodore
Commodore
User avatar

Joined: Sun Jan 08, 2006 7:32 pm
Posts: 148
Quote:
Should there be a check that the string passed to to the method is not nil or it works OK all the same?
I had not tested that. I have now. It works properly and makes/leaves the clipboard empty.


Top
   
 Post subject: Re: Trunk nightly
PostPosted: Sat Oct 07, 2017 6:13 pm 
Offline
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral

Joined: Wed Feb 28, 2007 7:54 am
Posts: 5029
Fantastic, patch committed. Thanks.


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 989 posts ]  Go to page Previous 162 63 64 65 66

All times are UTC


Who is online

Users browsing this forum: No registered users and 13 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
cron
Powered by phpBB® Forum Software © phpBB Limited