Oolite Bulletins

Got a bit of a scare with this, but it seems it's all good. Cody, your log is full of this stuff: What happened is that you accidentally turned on the collisions check debug flag, which is activated by pausing and pressing "b". The trunk is still stable (phew).

<scratches head - chortles> Pause+b? No idea how I could've done that, but there you go - thanks!

_________________
Knowledge is a deadly friend, if no one sets the rules
The fate of all mankind, I see, is in the hands of fools

Cool! I'd missed those updates as edits don't show as a new post.

_________________
Knowledge is a deadly friend, if no one sets the rules
The fate of all mankind, I see, is in the hands of fools

The auto-updater seems to be working.

_________________
Knowledge is a deadly friend, if no one sets the rules
The fate of all mankind, I see, is in the hands of fools

Well, the server is temporarily up, since there were some code updates.
It is still unstable, though.

_________________
"Any sufficiently advanced information is indistinguishable from noise." [Newman, Lachmann, Moore]

For me, the direction cue indicator in the HUD is broken in head of master.
Probably since 24bf8a05.

Changing this:
[[_reticleColors objectAtIndex:cueColorIndex] greenComponent]
to this:
[(OOColor*)[_reticleColors objectAtIndex:cueColorIndex] greenComponent]
(for all components in both arrays)
fixes it.

It also gets rid of compiler warnings for "Multiple Methods for xxxComponent".

Here is a diff that does just that.
This one is a bit nicer.


(OSX 10.10.5, xcode 7.1)

No problem merging your fix (the second one is the good one to go with), but what exactly was broken with the direction cue before?

It did not show up at all.

I noticed it missing, checked equipment and OXPs, then realised I ran trunk. Tried 1.84 and it was there.
So I looked at where it should be drawn, saw a bunch of warnings and a recent change. Tried this and it worked.

I don't know why. Stepping through in the debugger, it goes into OOColor, not NSColor, but afterwards, both arrays show {0,0,0,0}. Even when running debug build, which I guess doesn't optimize it away.

I could look into it a bit more later.

I think your fix is OK and will commit it shortly. As far as I can tell it is the same code behaviour, which is why I asked what was wrong. It is actually quite a bit cleaner than what we had there. Also, please check your PMs in a couple of minutes.

The retricle direction cue indicator should now be back on the Macs. I committed also a few more warning fixes of the same type as those corrected by hoqllnq, so now the reticle should be OK also for targeting wormholes.

Here is another one.
It implements MyOpenGLView::stringToClipboard() for Mac,
so you can get the OXP info URLs from the manager.

By the way, is this the appropriate place to post these, seeing as it is not a bug report, or is there a 'patch submission'-thread?

Thanks for that. Should there be a check that the string passed to to the method is not nil or it works OK all the same? Unfortunately I cannot test it myself. If it is OK, I will commit this once we have a confirmation.
The best way to send in patches is to submit them as pull requests on github. You can find information on how to do this here.

I had not tested that. I have now. It works properly and makes/leaves the clipboard empty.

Fantastic, patch committed. Thanks.

Terrastorage is down - is the latest Windows nightly missing from GitHub? Or am I missing something?

_________________
Knowledge is a deadly friend, if no one sets the rules
The fate of all mankind, I see, is in the hands of fools