(Release) Station Dock Control OXP

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: another_commander, winston

User avatar
phkb
Commodore
Commodore
Posts: 2675
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: (Release) Station Dock Control OXP

Post by phkb »

Damocles Edge wrote:
Sun Jul 29, 2018 1:33 am
I think I've found an oxp compatibility issue between station dock control oxp and equipment by ship class.
It's a small thing but since using equipment by ship class, I have never been able to get any ship destination information from "Corolis Station Traffic Control" (I was getting a ship list - just no destination or option to launch before / after.
I've just published an update to SDC which (fingers-crossed) should fix the issue with Equipment By Ship Class. I wasn't able to reproduce the error, but your log file did show up a number of issues which I hope this update will correct. Let me know what you find.

User avatar
phkb
Commodore
Commodore
Posts: 2675
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: (Release) Station Dock Control OXP

Post by phkb »

Version 1.1.20 is now available, which should fix the issue with docks sometimes being empty, and SDC sometimes not being able to allocation ships to docks.

User avatar
phkb
Commodore
Commodore
Posts: 2675
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: (Release) Station Dock Control OXP

Post by phkb »

Version 1.1.21 has just been released. In this version:
  • Added flag (accessible via Library Config) to turn of RandomShipName's ship names in the Docking list MFD.
  • Ensured stations in interstellar space do not get dock lists.
  • Turned off some debug messages.
  • Bug fixes.

User avatar
Milo
---- E L I T E ----
---- E L I T E ----
Posts: 361
Joined: Mon Sep 17, 2018 5:01 pm

Re: (Release) Station Dock Control OXP

Post by Milo »

Code: Select all

Warning (strict mode): reference to undefined property this.$repopulatorFrequencyIncoming.thargoidStrike
    Active script: oolite-populator 1.89
    stationdockcontrol_populator.js, line 213:
    	if (Math.random() < this.$repopulatorFrequencyIncoming.thargoidStrike) {

> worldScripts["oolite-populator"].$repopulatorFrequencyIncoming.thargoidStrikes  // note the s at the end, missing from the line above
0

Warning (strict mode): reference to undefined property this._systemDockingData[i]
    Active script: StationDockControl 1.1.23
    stationdockcontrol.js, line 5503:
    				var dta = JSON.stringify(this._systemDockingData[i]); // I think this can be fixed by adding && this._systemDockingData[i] to the preceding if condition

User avatar
phkb
Commodore
Commodore
Posts: 2675
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: (Release) Station Dock Control OXP

Post by phkb »

Nice catch. Particularly because this looks like a bug that exists in the core code as well (as SDC's repopulator function is largely a copy of that).

User avatar
phkb
Commodore
Commodore
Posts: 2675
Joined: Tue Jan 21, 2014 10:37 pm
Location: [p]laying [h]ard and [k]icking [b]utt somewhere in G7...

Re: (Release) Station Dock Control OXP

Post by phkb »

Fixed in 1.1.24, PR added to fix core code.

User avatar
Milo
---- E L I T E ----
---- E L I T E ----
Posts: 361
Joined: Mon Sep 17, 2018 5:01 pm

Re: (Release) Station Dock Control OXP

Post by Milo »

Saved game file here: https://easyupload.io/t85161

There's a Python named Freebooter of Orrere docked at the main station, crewed by a Galcop's Most Wanted fugitive, which appears twice on the traffic control list, with identical information except for docking bay and departure time.

Post Reply